crac
crac copied to clipboard
8352394: [CRaC] AOT class linking cannot archive jdk.internal.crac.Core$Priority
Fixes (or rather works around) the incompatibility with AOT class linking by converting jdk.internal.crac.Core$Priority into a usual class. We can convert it back to enum when CDS either starts supporting archiving Reference objects or stops aborting the archiving when it stumbles upon an unsupported object.
An alternative approach would be to make CDS treat this particular enum class specially and don't archive it in initialized state but messing with CDS internals can lead to many conflicts later.
This is a draft because after implementing I noticed JDK-8344140 which restricted the set of AOT-initialized enums — maybe jdk.internal.crac.Core$Priority is not in the restricted set. We should get JDK-8344140 integrated as part of jdk 25+6 and see if the issue resolves itself.
Progress
- [x] Change must not contain extraneous whitespace
Issue
- JDK-8352394: [CRaC] AOT class linking cannot archive jdk.internal.crac.Core$Priority (Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/213/head:pull/213
$ git checkout pull/213
Update a local copy of the PR:
$ git checkout pull/213
$ git pull https://git.openjdk.org/crac.git pull/213/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 213
View PR using the GUI difftool:
$ git pr show -t 213
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/crac/pull/213.diff
:wave: Welcome back tpushkin! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@TimPushkin This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Still relevant, at least until 25+6 is merged
After 25+6 has been merged all of the problematic tests now pass so this change is no longer needed