babylon icon indicating copy to clipboard operation
babylon copied to clipboard

Test for creating a module of functions from invocations

Open PaulSandoz opened this issue 1 year ago • 3 comments

Given a set of reflectable methods that form a call graph, we can create a code model that is a module operation containing the functions in that graph where invocation operations are replaced with function call operations. Starting from the a model of a method, we can traverse it for invocation operations. If the invocation operation's method reference can be resolved to a method and the method has a model then that model is added to the module, the invocation operation is replaced with a function call operation, and it is traversed for invocation operations and so on.


Progress

  • [x] Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/81/head:pull/81
$ git checkout pull/81

Update a local copy of the PR:
$ git checkout pull/81
$ git pull https://git.openjdk.org/babylon.git pull/81/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 81

View PR using the GUI difftool:
$ git pr show -t 81

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/81.diff

Webrev

Link to Webrev Comment

PaulSandoz avatar May 21 '24 21:05 PaulSandoz

:wave: Welcome back psandoz! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 21 '24 21:05 bridgekeeper[bot]

@PaulSandoz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Test for creating a module of functions from invocations

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the code-reflection branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

openjdk[bot] avatar May 21 '24 21:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 21 '24 21:05 mlbridge[bot]

/integrate

PaulSandoz avatar May 28 '24 18:05 PaulSandoz

Going to push as commit 4bdc86cf4a7090fc2cf44bae4cc9e4cc3fb952da. Since your change was applied there have been 19 commits pushed to the code-reflection branch:

  • eea106e1ea9566b14abafa959809f52b6202ad4e: At least one element in 'flexible array members' for some OpenCL comp…
  • 794db764f0b5f887abeb47511967663060b40b1a: create cuda version of new squares demo
  • 296adf034c4b088c855b64c07355f48ee9bc1886: initial work dumping schema from native
  • 0fbbbabff57f667f75db68c1b7a18827e7397b91: OpWriter block naming align with block indexes
  • 0bee7cb80243a67786fa0d4a1d2c05f1aae39a28: added some examples to migrate to hat
  • 97bfd7da9dfff0b8deb713b996a3be99be109e74: Hat sync with cuda changes
  • 9477fa0b630558379ee301a37f24cb94c5dfd359: Hat sync with cuda changes
  • 02aa9965f701e5e51fe897e199ee44c498de154f: Hat find cuda ill access
  • 1491ae304c998114a37788f33b4d64ffd6b314d4: Hat opencl cuda mergees
  • 185bb8cae550a9c3d942f1f47ecca6bd58179e0a: Clion CMakeLists.txt updates for ubuntu opencl
  • ... and 9 more: https://git.openjdk.org/babylon/compare/4f01364a50c7bf7a04600e8365bdc7031b2b8172...code-reflection

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 28 '24 18:05 openjdk[bot]

@PaulSandoz Pushed as commit 4bdc86cf4a7090fc2cf44bae4cc9e4cc3fb952da.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 28 '24 18:05 openjdk[bot]