babylon
babylon copied to clipboard
BytecodeLift implementation progress + SlotOp
In this patch:
- lifting of shifts, instanceof, stack ops
- fixes of types resolution and conversions in generator
- enabled stack for conditional branches
- fixed lift to survive additional labels in the code
- implemented LocalsTypeMapper to support SlotOp for lift
- implemented SlotOp and SlotSSA for lift
Progress
- [x] Change must not contain extraneous whitespace
Contributors
- Paul Sandoz
<[email protected]>
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/80/head:pull/80
$ git checkout pull/80
Update a local copy of the PR:
$ git checkout pull/80
$ git pull https://git.openjdk.org/babylon.git pull/80/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 80
View PR using the GUI difftool:
$ git pr show -t 80
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/80.diff
Webrev
:wave: Welcome back asotona! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@asotona This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
BytecodeLift implementation progress + SlotOp
Co-authored-by: Paul Sandoz <[email protected]>
Reviewed-by: psandoz
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 6 new commits pushed to the code-reflection branch:
- d49ac72ef3145c95b8be12443fc231dffcada957: fix opencl buffer created by last cuda fix..
- 0e2b2deb2dd8b8c5d08c7346d45aabe7f3394d8e: Fixed Race Condition in PTX nvcc compiler. Also atomicInc->atomicAdd
- 1cfb2ca06162ca75a206c9877fd65b750303d385: Add CUDA Clion artifacts and cleanup cuda backend
- b55e2964c64b214302cf8f09021ae443ccdd6c0e: Added Clion CMakefile to backends reformated cpp/h files
- f9b5a0a0043b6dfe20d682b4ea44400b1cd6aa3c: Hat initial implementation and build infrastructure
- db004979307b5e1785071496f2144d91168832aa: HAT needs public access to TranslateToSpirvModel
Please see this link for an up-to-date comparison between the source branch of this pull request and the code-reflection branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.
@asotona this pull request can not be integrated into code-reflection due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:
git checkout bytecode-round-5-slots
git fetch https://git.openjdk.org/babylon.git code-reflection
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge code-reflection"
git push
/contributor add @PaulSandoz
@asotona
Contributor Paul Sandoz <[email protected]> successfully added.
/integrate
Going to push as commit fda73bd58170a75feaccbc0e6ad7a313655e70bb.
Since your change was applied there have been 7 commits pushed to the code-reflection branch:
- 9839e4b4f90d79f2134c1a61d245a47296c83d2f: add cmake opencl stanza for non Apple machines
- d49ac72ef3145c95b8be12443fc231dffcada957: fix opencl buffer created by last cuda fix..
- 0e2b2deb2dd8b8c5d08c7346d45aabe7f3394d8e: Fixed Race Condition in PTX nvcc compiler. Also atomicInc->atomicAdd
- 1cfb2ca06162ca75a206c9877fd65b750303d385: Add CUDA Clion artifacts and cleanup cuda backend
- b55e2964c64b214302cf8f09021ae443ccdd6c0e: Added Clion CMakefile to backends reformated cpp/h files
- f9b5a0a0043b6dfe20d682b4ea44400b1cd6aa3c: Hat initial implementation and build infrastructure
- db004979307b5e1785071496f2144d91168832aa: HAT needs public access to TranslateToSpirvModel
Your commit was automatically rebased without conflicts.
@asotona Pushed as commit fda73bd58170a75feaccbc0e6ad7a313655e70bb.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.