babylon
babylon copied to clipboard
Remove minor unnecessary changes from main javac codebase
This PR undoes some unnecessary changes to the javac code:
LambdaToMethodstill mentions theQUOTABLEflag, which is no longer in useSymtabhas an helper method to load classes from a string name, but that's not really requiredTreeInfodefines a new helper function to detectsuperin an expression. Further analysis revealed this was unnecessary (as we can piggy back on the method reference kind instead)
Progress
- [x] Change must not contain extraneous whitespace
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/711/head:pull/711
$ git checkout pull/711
Update a local copy of the PR:
$ git checkout pull/711
$ git pull https://git.openjdk.org/babylon.git pull/711/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 711
View PR using the GUI difftool:
$ git pr show -t 711
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/711.diff
Using Webrev
:wave: Welcome back mcimadamore! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@mcimadamore This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
Remove minor unnecessary changes from main javac codebase
Reviewed-by: psandoz
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 3 new commits pushed to the code-reflection branch:
- d7107ab9d5903e5062ca327319b2d2a44d5f29e7: Make java @hat/bld less noisy by default
- 364743678e6382eefab0ac36976640bf76a34ee8: [hat] Compilation phases formatted with sub-phase
- 5b7b3b661b079e2cb04fba9199c2a19d60e87ef5: [docs] Babylon and HAT builds and with HAT testing updated
Please see this link for an up-to-date comparison between the source branch of this pull request and the code-reflection branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.
/integrate
Going to push as commit b07ea22c6cac90defb932c39425461f9922eccb7.
Since your change was applied there have been 4 commits pushed to the code-reflection branch:
- fa097e590fc5bcbf74b75a123939cadad59b3ed3: Fix javadoc issues
- d7107ab9d5903e5062ca327319b2d2a44d5f29e7: Make java @hat/bld less noisy by default
- 364743678e6382eefab0ac36976640bf76a34ee8: [hat] Compilation phases formatted with sub-phase
- ... and 1 more: https://git.openjdk.org/babylon/compare/b85eeb20e075b4185b565dfaa1eb89608c528315...code-reflection
Your commit was automatically rebased without conflicts.
@mcimadamore Pushed as commit b07ea22c6cac90defb932c39425461f9922eccb7.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.