babylon icon indicating copy to clipboard operation
babylon copied to clipboard

Detect if a java switch is case constant

Open mabbay opened this issue 1 week ago • 3 comments

Add the logic to check if a switch op is case constant.


Progress

  • [x] Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/710/head:pull/710
$ git checkout pull/710

Update a local copy of the PR:
$ git checkout pull/710
$ git pull https://git.openjdk.org/babylon.git pull/710/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 710

View PR using the GUI difftool:
$ git pr show -t 710

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/710.diff

Using Webrev

Link to Webrev Comment

mabbay avatar Nov 26 '25 09:11 mabbay

:wave: Welcome back mabbay! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Nov 26 '25 09:11 bridgekeeper[bot]

@mabbay This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Detect if a java switch is case constant

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the code-reflection branch:

  • d7107ab9d5903e5062ca327319b2d2a44d5f29e7: Make java @hat/bld less noisy by default
  • 364743678e6382eefab0ac36976640bf76a34ee8: [hat] Compilation phases formatted with sub-phase
  • 5b7b3b661b079e2cb04fba9199c2a19d60e87ef5: [docs] Babylon and HAT builds and with HAT testing updated
  • ... and 3 more: https://git.openjdk.org/babylon/compare/e644ddea433ebb754e1cf9b8e66bf6a577ecd319...code-reflection

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

openjdk[bot] avatar Nov 26 '25 09:11 openjdk[bot]

Webrevs

mlbridge[bot] avatar Nov 26 '25 09:11 mlbridge[bot]

I pushed the changes directly to https://github.com/openjdk/babylon/pull/706.

mabbay avatar Dec 01 '25 16:12 mabbay