babylon icon indicating copy to clipboard operation
babylon copied to clipboard

Published 20 hours ago • verified publisher icon openjdk

8337162: Support primitives in patterns

Open mabbay opened this issue 1 year ago • 4 comments

Support primitives in patterns

Progress

  • [x] Change must not contain extraneous whitespace

Issue

  • JDK-8337162: Support primitives in patterns (Task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/246/head:pull/246
$ git checkout pull/246

Update a local copy of the PR:
$ git checkout pull/246
$ git pull https://git.openjdk.org/babylon.git pull/246/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 246

View PR using the GUI difftool:
$ git pr show -t 246

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/246.diff

Webrev

Link to Webrev Comment

mabbay avatar Oct 02 '24 03:10 mabbay

:wave: Welcome back mabbay! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 02 '24 03:10 bridgekeeper[bot]

@mabbay This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337162: Support primitives in patterns

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1187 new commits pushed to the code-reflection branch:

  • b5ef3448d0a9847fe47ab84f64e335629ea8a316: Simplified maven copy to build dir
  • f928e7be46d569b2567015002ff1abd2b6fa7f7d: Exception regions patch
  • d04447d4b0aa9cb0eca60a6758f6e38edcaa77a4: Unreachable method or lambda exit
  • f4a8b2d9e00ea5fe0e598727b142bfd9888430fd: Added OpWrapper for CoreOp.NegOp (needed for blackscholes)
  • 09bd0bbc38441646d5e74d97669a57e5b4349e3a: Bldr provides access to jextract
  • de2faf947c3bb32ea4417352317e836738055dbc: Ensure exception region exits are generated
  • c750ca89ffc2c96f1202ee9787393890df8be3f2: Cleanup cmake handoff from maven and from bldr
  • 9343454b24770d13b5a1cbfd7b08fcc2be14c7d5: Captured constants in variables
  • 8a8e5b2f52810a4b547c334423a441d4227c1855: Simplify code generation for quotable lambdas not to require duplicate capture argument lists
  • cfffc996fcc25f61f376c3d41a7774e59557bea5: 8337161: Support record pattern for generic records
  • ... and 1177 more: https://git.openjdk.org/babylon/compare/971b90fa70eaa31810d3658f2f689c2b1ea4c4be...code-reflection

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

openjdk[bot] avatar Oct 02 '24 03:10 openjdk[bot]

Webrevs

mlbridge[bot] avatar Oct 02 '24 03:10 mlbridge[bot]

You need to add test for all the primitive types.

What about i instanceof Integer _ and i instanceof Number _ will you address that in this PR a subsequent PR?

I will add more tests

mabbay avatar Oct 03 '24 00:10 mabbay

We will support other kind of conversions in a subsequent PR.

mabbay avatar Oct 22 '24 18:10 mabbay

/integrate

mabbay avatar Oct 22 '24 18:10 mabbay

Going to push as commit 853cb64b501b64c78e13526182b9b8578f2b077f. Since your change was applied there have been 1187 commits pushed to the code-reflection branch:

  • b5ef3448d0a9847fe47ab84f64e335629ea8a316: Simplified maven copy to build dir
  • f928e7be46d569b2567015002ff1abd2b6fa7f7d: Exception regions patch
  • d04447d4b0aa9cb0eca60a6758f6e38edcaa77a4: Unreachable method or lambda exit
  • f4a8b2d9e00ea5fe0e598727b142bfd9888430fd: Added OpWrapper for CoreOp.NegOp (needed for blackscholes)
  • 09bd0bbc38441646d5e74d97669a57e5b4349e3a: Bldr provides access to jextract
  • de2faf947c3bb32ea4417352317e836738055dbc: Ensure exception region exits are generated
  • c750ca89ffc2c96f1202ee9787393890df8be3f2: Cleanup cmake handoff from maven and from bldr
  • 9343454b24770d13b5a1cbfd7b08fcc2be14c7d5: Captured constants in variables
  • 8a8e5b2f52810a4b547c334423a441d4227c1855: Simplify code generation for quotable lambdas not to require duplicate capture argument lists
  • cfffc996fcc25f61f376c3d41a7774e59557bea5: 8337161: Support record pattern for generic records
  • ... and 1177 more: https://git.openjdk.org/babylon/compare/971b90fa70eaa31810d3658f2f689c2b1ea4c4be...code-reflection

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Oct 22 '24 18:10 openjdk[bot]

@mabbay Pushed as commit 853cb64b501b64c78e13526182b9b8578f2b077f.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Oct 22 '24 18:10 openjdk[bot]