OpenID4VP icon indicating copy to clipboard operation
OpenID4VP copied to clipboard

Presentation Exchange doesn't have the `mdoc-mso` entry in its Registry?

Open samuelgoto opened this issue 1 year ago • 3 comments

I was reading the mdoc section of this spec and ran into this code example of Presentation Exchange:

"format":{
  "mso_mdoc":{
    "alg":[
      "EdDSA",
      "ES256"
    ]
  },
},

But following the Presentation Exchange spec leads me to this Registry, which doesn't seem to think mso_mdoc is a valid entry.

Is this just a spec bug?

samuelgoto avatar Feb 17 '24 00:02 samuelgoto

We haven't really been using DIF.PE registry, but rather defined credential format identifiers in OpenID4VP spec directly. It is a no-brainer to register these identifiers (including sd-jwt vc, etc) with PE if you think it is important, it just has not been prioritized.

Sakurann avatar Feb 17 '24 01:02 Sakurann

rather defined credential format identifiers in OpenID4VP spec directly

Can you point me where that's define in the OpenID4VP spec? Is there maybe a registry of formats that I may have missed?

samuelgoto avatar Feb 17 '24 18:02 samuelgoto

each section in Appendix A has a sentence The Credential format identifiers are .... Guess it could be clearer.

Sakurann avatar Feb 20 '24 20:02 Sakurann

Addressed in https://github.com/decentralized-identity/claim-format-registry/pull/11 please take a look for correctness

decentralgabe avatar Jun 20 '24 03:06 decentralgabe

LGTM. Resolving.

samuelgoto avatar Jun 20 '24 18:06 samuelgoto