AppAuth-iOS
AppAuth-iOS copied to clipboard
openid
Relax redirect URL matching for the forward slash path case
Based on issue #446 sometimes a trailing slash added to path for redirect url. Here a fix to make comparison regardless that trailing slash.
This issue affects react-native-app-auth lib: https://github.com/FormidableLabs/react-native-app-auth/issues/123 https://github.com/FormidableLabs/react-native-app-auth/issues/336
and a few others.
Thanks for the contribution @AlexPlekhov, could you sign the contributor agreements so we can get this merged?
Hi @petea, I've already done it immediately after creating PR. I hope you got email notifications. If didn't I'm ready to send those PDFs via email.
Thanks for the contribution @AlexPlekhov, could you sign the contributor agreements so we can get this merged?
Hi @petea, could you confirm that everything OK? I followed the steps in the contributor agreements. Please, write me back if I missed anything and still have to do something.
Would be great to have this PR merged as it fixes an issue with Azure AD we have been experiencing. The Azure Portal gives us a redirect URI which looks like msauth.com.example.app://auth to use with our iOS app. But when the redirect back to our app happens they have appended a slash which breaks AppAuth's redirect URI validation. With the changes in this PR applied AppAuth happily accepts the redirect URI and proceeds.
Hi all, @petea,
I've resigned all docs as required by Mike Leszcz, was added to a WG, got a subscription email. But it's still in review. Have I missed anything again?
I think this should be merged, as this is mission critical for functioning apps that rely on third party services and thus cannot influence how the backend behaves.
@developerfromjokela note that there are workarounds for this situation discussed in #446.
@developerfromjokela note that there are workarounds for this situation discussed in #446.
Yep, we already did the same. But wants to help the community to not face with it again.
Hi @petea, will this get merged? We encountered this issue just today. We have support for multiple IdPs that support OIDC and customer wanted to use ADFS but it is not working cause ADFS appends / to the redirect uri 🤷🏽♂️
@davidkaya note that there is a straightforward workaround for this issue that is detailed in #446.
Can we get this PR moving again? I think the only remaining question is a missing comment? Would help in our case (using the Flutter AppAuth library where this is an issue as well (and mentioned workaround does not apply in our case)
@DelcoigneYves I did everything I could. Comments, formats - everything has been in place already.
@DelcoigneYves @petea @davidkaya Hi folks! I give up. I see only resistance against this PR and ignorance. May be you will be more successful to resolve this issue on your way. I will close it soon.
@petea LGTM! Can we please now merge it? 🙂 https://github.com/openid/AppAuth-iOS/blob/master/CONTRIBUTING.md#pull-request-reviews
