replace # portion of redirect url with ? in order to capture url components

[ahmednour25689]

…onents

iOS 12.* support for redirect call back not fired in app delegate

[codecov-io]

Codecov Report

Merging #521 into master will increase coverage by 0.02%. The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
+ Coverage   72.13%   72.15%   +0.02%     
==========================================
  Files          63       63              
  Lines        5412     5416       +4     
==========================================
+ Hits         3904     3908       +4     
  Misses       1508     1508              

Impacted Files	Coverage Δ
Source/OIDURLQueryComponent.m	92.85% <80.00%> (+0.23%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 217ee92...7a6094d. Read the comment docs.

[WilliamDenniss]

This comes up from time to time. The # fragment is for the token flow which AppAuth doesn't support.

I would suggest implementing this in your own OIDUserAgent instead, if you really need this. You can clone the standard one, modify the URL however you like, before passing it to AppAuth. These user agents are an extension point for AppAuth, so you don't need to fork the library to follow this.

[codecov-commenter]

:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

:x: Patch coverage is 61.76471% with 13 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 72.06%. Comparing base (217ee92) to head (7a6094d). :warning: Report is 95 commits behind head on master.

Files with missing lines	Patch %	Lines
Source/OIDAuthorizationService.m	47.36%	10 Missing :warning:
Source/OIDURLQueryComponent.m	80.00%	3 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
- Coverage   72.13%   72.06%   -0.07%     
==========================================
  Files          63       63              
  Lines        5412     5435      +23     
==========================================
+ Hits         3904     3917      +13     
- Misses       1508     1518      +10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.