core-v-verif icon indicating copy to clipboard operation
core-v-verif copied to clipboard

Do-nothing class method overrides

Open MikeOpenHWGroup opened this issue 4 years ago • 3 comments

In core-v-verif there are 3 files that override a method of a parent class, but only call super.method() with the same arguments. You are in the "assignees" list of this issue because git believes you authored one or more of these.

The Verissimo linter flags these as violation SVTB.7.26.

Possible resolutions:

  1. Accept the use "do nothing overrides" and create a project-wide waiver for SVTB.7.26.
  2. Remove all "do nothing overrides".
  3. Waive, or not, on a case-by-case basis.

Steps to Reproduce

Lint checks are run every six hours - the link above will show all violations of this rule.

Additional context

This is a set of linter issues identified by the Verissimo SystemVerilog Testbench Linter. Please reach out to me directly if you have questions about the tool.

MikeOpenHWGroup avatar Oct 08 '21 16:10 MikeOpenHWGroup

All of my fixes should be in above PR (934)

strichmo avatar Oct 13 '21 14:10 strichmo

Awesome, thanks @strichmo. Over to you @datum-dpoulin.

MikeOpenHWGroup avatar Oct 13 '21 23:10 MikeOpenHWGroup

Fix in PR #943

datum-dpoulin avatar Oct 14 '21 20:10 datum-dpoulin