openhab-android
openhab-android copied to clipboard
openhab
Stop notify about no notification every time
Is your feature request related to a problem? Please describe.
On every start app do reminder about not alloved notification and block control panel with this notification.
Describe the solution you'd like
App should ask about enable notification only one time on first start.
Describe alternatives you've considered
Don't reminder about not enabled notification at all
Additional context
We should remove reminder about missing some features:
The easiest way to hide this message is to allow notifications, but I guess you don't want that. May I ask why don't you want to enable notifications?
@mueller-ma according to the principle of least privilege (POLP) app (in this context) should have minimum rights. I don't expect any notifications from app, as result notifications must be disabled.
according to the principle of least privilege (POLP) app (in this context) should have minimum rights
That's correct in general, but in this case the permission doesn't grant access to any data. It just allows sending notification. Also the user is notified when this permission is used is misused as a notification is shown then.
@maniac103 What do you think about this? Notifications are used for myopenhab push notifications, but also for errors on background tasks, which include voice widgets, sending device info and scanning NFC tags. Maybe add a "Never remind" action to this snackbar?
Yeah, a 'Got it' button should be OK when combined with an info text in the prefs panel, which could have a button to re-request the permission grant.
I removed notification for local build, but I guess it is not expected fix but it is word :) https://github.com/openhab/openhab-android/compare/main...maxx-ukoo:openhab-android:mk_remove_notify_about_no_permission?expand=1