openhab-android icon indicating copy to clipboard operation
openhab-android copied to clipboard

Show local/remote connection only in debug mode

Open mueller-ma opened this issue 1 year ago • 6 comments

I don't see any use in these messages except for debugging, so show them only in debug mode.

mueller-ma avatar Jan 15 '24 18:01 mueller-ma

Personally I only have one use case: having a VPN connection active over a flaky mobile network. In that case the local server should be chosen, but due to the flaky mobile network it's sometimes not reachable. Maybe we should retry the connection check in the background in that case.

maniac103 avatar Jan 15 '24 19:01 maniac103

I don't understand your use case. How does the snackbar influence the connection?

mueller-ma avatar Jan 22 '24 16:01 mueller-ma

It doesn't, but it tells me the point in time where it's pointless to wait any longer for the content to load. I use myOH only for notifications, so the remote server won't give me contents either, this without the snack bar I won't be able to distinguish 'tries to establish local connection' from 'futile attempt to establish remote connection'.

maniac103 avatar Jan 22 '24 16:01 maniac103

In my environment I have an internal private IP address and public static IP address. For some reason, probably because the provider wants so and I cannot adjust the router to do otherwise, I cannot access the external IP address from the internal network. I find it useful to see whether OpenHAB-Android tries to connect to the internal or to the external network, and which one fails.

In fact I asked at https://github.com/openhab/openhab-android/issues/3417 to spell whether local or remote connection is retried after failure.

I think that “Restricting the local connections based on Wi-Fi name” shall be used as speedup - https://github.com/openhab/openhab-android/issues/3414 . In this case I consider it good, if it is spelled explicitly whether the connection is made to local or remote server.

dilyanpalauzov avatar Jan 22 '24 19:01 dilyanpalauzov

What do you think about showing "Connecting to local/remote server" in the ProgressFragment?

mueller-ma avatar Feb 03 '24 16:02 mueller-ma

As far as this question is for me, I do not know what the ProgressFragment is.

dilyanpalauzov avatar Feb 03 '24 18:02 dilyanpalauzov

What do you think about showing "Connecting to local/remote server" in the ProgressFragment?

That's not possible any longer as the skeleton view is used while loading.

mueller-ma avatar Aug 13 '24 17:08 mueller-ma