qfieldcloud
qfieldcloud copied to clipboard
Qf 2134 fix sentry logging
Some more improvements to sentry:
- ~minor improvement to exception handler (log 4xx as info, 5xx as exceptions)~ Actually, they could still indicate some serious issues e.g. in QField (for example 3528247758 could indicate some but in QField). Let's continue to manually decide which exception we want to report or not (and in the longer term, do that in the code itself rather than in the uncaught exception handler)
- ~mute sentry issue 3528247758 (error -> info)~ (see above)
- include SENTRY_RELEASE env var, so that we can use features like "resolve in next release" in sentry
TODO BEFORE MERGE
- [ ] the release pipeline must be adapted to set a
SENTRY_RELEASEenv var (or maybe cleaner to write it to.envso it survives manual docker-compose up).
Task linked: QF-2134 Review and fix issues on Sentry
I think the only think we should do before merging this PR is to find an automatic way to set the SENTRY_RELEASE env variable. I believe we can get when building the containers with the docker compose setup we have.
I think the only think we should do before merging this PR is to find an automatic way to set the SENTRY_RELEASE env variable. I believe we can get when building the containers with the docker compose setup we have.
Yes, for that do you want to take over ? (I'm happy to do it, but then need some guidance as to how deployment is set up)
@olivierdalang greetings! Thanks for this PR, it took only 2 years and one job change to fix :) I will close and reopen, so you don't get bombarded with notifications about this PR.
Task linked: QF-2134 Review and fix issues on Sentry