openfga.dev icon indicating copy to clipboard operation
openfga.dev copied to clipboard

feat(openfga): remove almost all DSL/JSON tabs with 1 exception

Open ttrzeng opened this issue 7 months ago • 7 comments

Description

References

Review Checklist

  • [ ] I have clicked on "allow edits by maintainers".
  • [ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • [ ] The correct base branch is being used, if not main
  • [ ] I have added tests to validate that the change in functionality is working as expected

ttrzeng avatar May 14 '25 15:05 ttrzeng

CLA Missing ID CLA Not Signed

  • :x: The email address for the commit (005bfc7965360c7bcd338284a19c924e119d6b00) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

PR Preview Action v1.6.1 :---: |

:rocket: View preview at
https://openfga.github.io/openfga.dev/pr-preview/pr-1031/

|
Built to branch gh-pages at 2025-05-28 21:32 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

github-actions[bot] avatar May 14 '25 15:05 github-actions[bot]

@ttrzeng can you pls add before & after screenshots?

cikasfm avatar May 14 '25 17:05 cikasfm

@ttrzeng can you pls add before & after screenshots?

Before: Screenshot 2025-05-14 at 2 22 21 PM

After: Screenshot 2025-05-14 at 2 21 57 PM

ttrzeng avatar May 14 '25 18:05 ttrzeng

Should we also decrease the margin on the top of the DSL text? cc @dongniwang

aaguiarz avatar May 14 '25 18:05 aaguiarz

Should we also decrease the margin on the top of the DSL text? cc @dongniwang

FYI: what it will look like with less margin top: Screenshot 2025-05-14 at 3 27 17 PM

ttrzeng avatar May 14 '25 19:05 ttrzeng

Thanks @aaguiarz for flagging it. I did a little bit more investigation, it seems like the margin or extra padding is not a consistent thing across all pages. Some of the code blocks have the extra padding. See the configuration page for example. image I'd suggest @ttrzeng to keep this PR to focus on removing the tab and have a separate effort to look into why we have extra padding on some of them. cc @dyeam0

dongniwang avatar May 14 '25 19:05 dongniwang