java-sdk icon indicating copy to clipboard operation
java-sdk copied to clipboard

feat: improvements to OpenTelemetry metrics

Open evansims opened this issue 1 year ago • 1 comments

Description

This PR updates the changes made in #94 to support a number of new and overlook attributes previously not implemented, and improves clarity in the wording of descriptions. It also updates the attribute naming convention based on feedback.

References

Generated from https://github.com/openfga/sdk-generator/pull/402

Review Checklist

  • [x] I have clicked on "allow edits by maintainers".
  • [x] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • [x] The correct base branch is being used, if not main
  • [x] I have added tests to validate that the change in functionality is working as expected

evansims avatar Jul 23 '24 01:07 evansims

Codecov Report

Attention: Patch coverage is 90.72581% with 23 lines in your changes missing coverage. Please review.

Project coverage is 30.88%. Comparing base (489ca8e) to head (f1ad4e1).

Files Patch % Lines
...ain/java/dev/openfga/sdk/telemetry/Attributes.java 73.91% 1 Missing and 11 partials :warning:
...dev/openfga/sdk/api/client/HttpRequestAttempt.java 66.66% 5 Missing :warning:
...v/openfga/sdk/api/configuration/Configuration.java 50.00% 2 Missing and 1 partial :warning:
...a/sdk/api/configuration/ConfigurationOverride.java 50.00% 2 Missing :warning:
src/main/java/dev/openfga/sdk/api/OpenFgaApi.java 99.23% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #95      +/-   ##
============================================
+ Coverage     29.20%   30.88%   +1.67%     
- Complexity      815      842      +27     
============================================
  Files           166      168       +2     
  Lines          6030     6185     +155     
  Branches        650      679      +29     
============================================
+ Hits           1761     1910     +149     
+ Misses         4186     4177       -9     
- Partials         83       98      +15     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 23 '24 01:07 codecov-commenter