faasd icon indicating copy to clipboard operation
faasd copied to clipboard

Updated install docs (sed) to accept keys with `/` in them

Open levb opened this issue 3 years ago • 2 comments

Description

Escaped the /s in the public key (sed command parameter)

Motivation and Context

I encountered an issue installing faasd, my key had multiple /s in it.

How Has This Been Tested?

My installation worked with the change

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Commits:

  • [X] I've read the CONTRIBUTION guide
  • [X] My commit message has a body and describe how this was tested and why it is required.
  • [X] I have signed-off my commits with git commit -s for the Developer Certificate of Origin (DCO)

Code:

  • [ ] My code follows the code style of this project.
  • [ ] I have added tests to cover my changes.

Docs:

  • [ ] My change requires a change to the documentation.
  • [X] I have updated the documentation accordingly.

levb avatar Jun 24 '22 14:06 levb

Thank you for your contribution. It seems that one or more of your commits have a "Signed-off-by" statement with an anonymous email address. The Developer Certificate of Origin (DCO) requires all commits to be signed off by genuine, contactable individuals. Please see our contributing guide.

### :bulb: Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name" git config --global user.email "[email protected]"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force. If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

derek[bot] avatar Jun 24 '22 14:06 derek[bot]

Hey @levb, Hope you're well.

Are you looking to use faasd within Mattermost? I believe we've had discussions with various folks in your org in the past about sponsorships and potential commercials etc.

Alex

alexellis avatar Aug 13 '22 19:08 alexellis