edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

feat: set links for CourseAuthoring discussion alert

Open CefBoud opened this issue 1 year ago • 3 comments

Description

There is an alert in CourseAuthoring MFE to inform about the usage of an upgraded version of discussion. This PR sets the links used in that alert instead of defaulting to the having clickable empty links.

Testing instructions

Please refer to the related MFE PR https://github.com/openedx/frontend-app-course-authoring/pull/1245

ref

BB-9079

CefBoud avatar Aug 30 '24 14:08 CefBoud

Thanks for the pull request, @CefBoud!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks avatar Aug 30 '24 14:08 openedx-webhooks

nitpick: you have a typo in the commit message. It should be:

feat: set links for CourseAuthoring discussion alert

pdpinch avatar Sep 09 '24 12:09 pdpinch

Good catch! Fixed.

CefBoud avatar Sep 09 '24 13:09 CefBoud

@pdpinch Yes. Please take care of the merge.

CefBoud avatar Sep 23 '24 17:09 CefBoud

Thank you for your contribution @CefBoud. My apologies for the delay in merging.

pdpinch avatar Sep 26 '24 15:09 pdpinch

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot avatar Sep 26 '24 16:09 edx-pipeline-bot

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot avatar Sep 26 '24 17:09 edx-pipeline-bot

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot avatar Sep 26 '24 17:09 edx-pipeline-bot

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot avatar Sep 26 '24 17:09 edx-pipeline-bot

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot avatar Sep 26 '24 18:09 edx-pipeline-bot

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot avatar Sep 26 '24 18:09 edx-pipeline-bot

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot avatar Sep 26 '24 19:09 edx-pipeline-bot

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot avatar Sep 26 '24 19:09 edx-pipeline-bot