edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

feat: add has_course_author_access to CourseHomeMetadataView response [BB-9082]

Open 0x29a opened this issue 1 year ago • 2 comments

Description

Adds has_course_author_access boolean to CourseHomeMetadataView. Currently it's used to control visibility of the "View as Staff" button here: https://github.com/openedx/frontend-app-learning/pull/1436

Testing

Open any unit in frontend-app-learning, open Network tab in your browser console, and search for meta there. There will be a single request, and its JSON response should contain has_course_author_access key. It should be False for all users that don't have access to Studio, especially those having the "Limited Staff" course team role.

0x29a avatar Aug 14 '24 16:08 0x29a

Thanks for the pull request, @0x29a!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks avatar Aug 14 '24 16:08 openedx-webhooks

OSPR management note: User-facing change, so will likely need product approval before we can move forward with engineering review and merge.

Marking as blocked for now.

CC @mphilbrick211

itsjeyd avatar Sep 07 '24 09:09 itsjeyd

OSPR management note: Product review complete, see https://github.com/openedx/platform-roadmap/issues/361#issuecomment-2429495888.

itsjeyd avatar Oct 24 '24 08:10 itsjeyd

@0x29a Can you please rebase the PR?

farhaanbukhsh avatar Oct 25 '24 17:10 farhaanbukhsh

@farhaanbukhsh, done.

0x29a avatar Oct 29 '24 11:10 0x29a

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot avatar Nov 28 '24 20:11 edx-pipeline-bot

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot avatar Dec 02 '24 14:12 edx-pipeline-bot