edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

Fix: Course team members are included in "Learners in the track" emails recipients

Open DmytroAlipov opened this issue 1 year ago • 4 comments

Description

This applies to bulk emails.

audit

To reproduce the problem follow these steps:

  1. By instructor for to Instructor
  2. Email
  3. Choose Learners in the Audit track or Learners in the Verified track, fill in all necessary fields
  4. Send an email
  5. Email received by instructor user who is in the corresponding track

Expected Result

Probably course team users should be excluded from those emails to "Learners in the corresponding track" same as they are excluded from emails sent to All learners.

https://edx.readthedocs.io/projects/open-edx-building-and-running-a-course/en/latest/manage_live_course/bulk_email.html#who-is-included-in-each-recipient-group

DmytroAlipov avatar Apr 25 '24 07:04 DmytroAlipov

Thanks for the pull request, @DmytroAlipov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks avatar Apr 25 '24 07:04 openedx-webhooks

@mphilbrick211 friendly ping

DmytroAlipov avatar Aug 01 '24 15:08 DmytroAlipov

@mphilbrick211 friendly ping

Hi @DmytroAlipov! We have this out to the community for review. Thank you for your patience.

mphilbrick211 avatar Aug 15 '24 15:08 mphilbrick211

@mphilbrick211 I can take the review on this.

farhaanbukhsh avatar Sep 02 '24 12:09 farhaanbukhsh

@farhaanbukhsh done

DmytroAlipov avatar Nov 30 '24 13:11 DmytroAlipov

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot avatar Dec 12 '24 11:12 edx-pipeline-bot

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot avatar Dec 12 '24 13:12 edx-pipeline-bot

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot avatar Dec 12 '24 13:12 edx-pipeline-bot