edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

fix: Unexpected "Copied_from_block" field in Advanced Settings #34370

Open qasimgulzar opened this issue 1 year ago • 3 comments

Issue Description:

I noticed that a new Copied_from_block field has appeared in Advanced Settings. image

However, having investigated this field, I still could not find an explanation for why it was needed here. At the moment it looks confusing. Perhaps when adding this functionality, they simply forgot to include copied_from_block in FIELDS_EXCLUDE_LIST.

Findings

I have investigated and it seems like an internal field which is automatically populating when pasting copied block in studio.

Solution Implemented:

Added copy_from_block to the FIELDS_EXCLUDE_LIST and then this field will not be shown in Advanced Settings.

qasimgulzar avatar Apr 04 '24 07:04 qasimgulzar

Thanks for the pull request, @qasimgulzar! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks avatar Apr 04 '24 07:04 openedx-webhooks

Hi @qasimgulzar! Just flagging that there's a failing check. Could you take a look when you have a moment?

mphilbrick211 avatar Apr 05 '24 00:04 mphilbrick211

@mphilbrick211 it is now passing all the checks.

qasimgulzar avatar Apr 08 '24 07:04 qasimgulzar

@qasimgulzar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Jun 17 '24 15:06 openedx-webhooks

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot avatar Jun 17 '24 16:06 edx-pipeline-bot

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot avatar Jun 17 '24 18:06 edx-pipeline-bot

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot avatar Jun 17 '24 18:06 edx-pipeline-bot

@qasimgulzar Thank you very much for your contribution to Upstream. Could you make a backport for the Redwood.master branch?

DmytroAlipov avatar Jun 17 '24 18:06 DmytroAlipov

Sure - I will create a backport PR for redwood

qasimgulzar avatar Jun 17 '24 18:06 qasimgulzar

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot avatar Jun 17 '24 19:06 edx-pipeline-bot