dynamic-localpv-provisioner icon indicating copy to clipboard operation
dynamic-localpv-provisioner copied to clipboard

feat(provisioner-localpv): Merge CAS config from PersistentVolumeClaim

Open niladrih opened this issue 1 year ago • 3 comments

Requires https://github.com/openebs/dynamic-localpv-provisioner/pull/191

This change merges the CAS config on the PVC with the SC (SC get preference in case of conflict), when provisioning volumes. Imports changes from @nobiit's PR https://github.com/openebs/dynamic-localpv-provisioner/pull/144.

niladrih avatar Jun 28 '24 07:06 niladrih

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 37.93%. Comparing base (2f165df) to head (6a5e8bf). Report is 10 commits behind head on develop.

Files Patch % Lines
cmd/provisioner-localpv/app/config.go 0.00% 8 Missing :warning:
...kg/kubernetes/api/apps/v1/deployment/deployment.go 0.00% 8 Missing :warning:
...kg/kubernetes/api/storage/v1/storageclass/build.go 0.00% 8 Missing :warning:
...ernetes/api/core/v1/persistentvolumeclaim/build.go 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #190      +/-   ##
===========================================
- Coverage    38.20%   37.93%   -0.28%     
===========================================
  Files           36       36              
  Lines         3348     3372      +24     
===========================================
  Hits          1279     1279              
- Misses        1987     2011      +24     
  Partials        82       82              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 01 '24 13:07 codecov-commenter

Thanks guys, I missed it. Thanks for helping me out.

nobiit avatar Jul 02 '24 07:07 nobiit

Thanks guys, I missed it. Thanks for helping me out.

No problem :)

niladrih avatar Jul 05 '24 05:07 niladrih