ods-jenkins-shared-library icon indicating copy to clipboard operation
ods-jenkins-shared-library copied to clipboard

enhance customisation options for buildconfig

Open tbugfinder opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe. It should be possible to configure buildconfig settings like the memory / cpu limits or buildfrom within odsComponentStageBuildOpenShiftImage. Currently a developer could tweak those settings once the buildconfig was deployed within an Openshift project.

It would also be beneficial to configure builds for build/execution speed.

Describe the solution you'd like Add an configuration option to odsComponentStageBuildOpenShiftImage.


spec:
  resources:
    limits:
      cpu: "1" 
      memory: "6Gi"
    requests:
      cpu: "200m"
      memory: "2Gi"

Describe alternatives you've considered

  • manual tweak of initial buildconfig

Additional context

I'm also wondering if the buildconfig couldn't default to e.g. 4 CPUs or 8 CPUs and 8Gi memory. This would improve developer experience a lot and it doesn't harm anything and shouldn't cost too much either in a cloud auto-scaling environment.

tbugfinder avatar Apr 26 '23 13:04 tbugfinder

I also miss here the config option to set the buildFrom attribute, maybe we could switch this issue to "enhance customisation config options for build stage" ?

gerardcl avatar Apr 26 '23 18:04 gerardcl

Could you paste the link to docs and an example?

tbugfinder avatar Apr 26 '23 19:04 tbugfinder

hi @tbugfinder ! sure!

  • docs
  • example would be when locally building postgres but on openshift building with redhat postgres based images etc (in the docs there is a code example)

gerardcl avatar Apr 27 '23 16:04 gerardcl