ods-jenkins-shared-library icon indicating copy to clipboard operation
ods-jenkins-shared-library copied to clipboard

mro pipeline generated empty commits

Open BraisVQ opened this issue 4 years ago • 4 comments
trafficstars

Describe the bug After I run the mro pipeline, I found out that it generated 4 commits, being only the first one with changes applied, the other 3 were empty commits

To Reproduce Steps to reproduce the behavior:

  1. configure the metadata.yml of the release manager to use a quickstarter
  2. run the mro pipeline into dev environment
  3. check the commits into the repository of the quickstarter

Expected behavior It should only be one commit into the repository.

Screenshots Captura

Affected version (please complete the following information):

  • OpenShift: 3.11
  • OpenDevStack 3.1

BraisVQ avatar Mar 18 '21 10:03 BraisVQ

"works as intended" so not a bug (it was done like this because it's simple).

But I agree it would be nicer not to do any commit if there is nothing to commit.

michaelsauter avatar Mar 18 '21 11:03 michaelsauter

Simplier for code the shared lib but is a headache for the final user. ugly repo with lot of tags, could confuse users as we promote dev artifacts to Q prod but anyway we tag in git, so user could thing he is getting latest changes when QA(git tag) but he in reality is getting Dev artifacts.

segator avatar Mar 18 '21 11:03 segator

I'd be highly interested in knowing the reasoning behind why the need for the 3 extra empty commits. Humbly asking, what purpose do they serve?

felipecruz91 avatar Mar 18 '21 11:03 felipecruz91

There's absolutely no purpose those empty commits serve. It's just that it "works" and simpler for shared lib code. Feel free to remove!

michaelsauter avatar Mar 18 '21 12:03 michaelsauter