ods-jenkins-shared-library
ods-jenkins-shared-library copied to clipboard
mro pipeline generated empty commits
Describe the bug After I run the mro pipeline, I found out that it generated 4 commits, being only the first one with changes applied, the other 3 were empty commits
To Reproduce Steps to reproduce the behavior:
- configure the metadata.yml of the release manager to use a quickstarter
- run the mro pipeline into dev environment
- check the commits into the repository of the quickstarter
Expected behavior It should only be one commit into the repository.
Screenshots
Affected version (please complete the following information):
- OpenShift: 3.11
- OpenDevStack 3.1
"works as intended" so not a bug (it was done like this because it's simple).
But I agree it would be nicer not to do any commit if there is nothing to commit.
Simplier for code the shared lib but is a headache for the final user. ugly repo with lot of tags, could confuse users as we promote dev artifacts to Q prod but anyway we tag in git, so user could thing he is getting latest changes when QA(git tag) but he in reality is getting Dev artifacts.
I'd be highly interested in knowing the reasoning behind why the need for the 3 extra empty commits. Humbly asking, what purpose do they serve?
There's absolutely no purpose those empty commits serve. It's just that it "works" and simpler for shared lib code. Feel free to remove!