opencv_contrib icon indicating copy to clipboard operation
opencv_contrib copied to clipboard

Complex division is not correct.

Open Youngjae-Lee opened this issue 2 years ago • 0 comments

https://github.com/opencv/opencv_contrib/blob/353e37e91f01ae16caca919806b7c38bd255db0c/modules/tracking/src/mosseTracker.cpp#L66-L71

The code above seems to have a discrepancy between the comment and the actual implementation of complex division. While the comment states that complex division is being implemented, the actual code does not align with the comment.

The incorrect implementation is, C_out.imag = -1 * (C1.imag + C2.real + C1.real * C2.imag), appears to calculate the imaginary part of the complex division. However, this implementation is incorrect for complex division.

Despite this discrepancy, is it possible that the code still runs correctly??

Youngjae-Lee avatar Jun 14 '23 07:06 Youngjae-Lee