opencv_contrib icon indicating copy to clipboard operation
opencv_contrib copied to clipboard

Update xfeatures2d.hpp

Open berak opened this issue 3 years ago • 1 comments

add missing CV_WRAP to MSDDetector::create()

resolves: #3356

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • [x] I agree to contribute to the project under Apache 2 License.
  • [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • [x] The PR is proposed to the proper branch
  • [x] There is a reference to the original bug report and related work
  • [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name.
  • [ ] The feature is well documented and sample code can be built with the project CMake

berak avatar Sep 16 '22 10:09 berak

Could you add small python test that detector is created correctly and minimally functional (returns non-zero features or something like this).

asmorkalov avatar Sep 20 '22 13:09 asmorkalov