opencv_contrib icon indicating copy to clipboard operation
opencv_contrib copied to clipboard

fix the bug that cannot detect multi qrcode when use_nn_detector is false

Open bit1002lst opened this issue 3 years ago • 7 comments

A new PR based on the top of 4.x and fix the conflicts related issus https://github.com/opencv/opencv_contrib/issues/3343

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • [x] I agree to contribute to the project under Apache 2 License.
  • [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • [x] The PR is proposed to the proper branch
  • [x] There is a reference to the original bug report and related work
  • [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name.
  • [x] The feature is well documented and sample code can be built with the project CMake

bit1002lst avatar Sep 09 '22 15:09 bit1002lst

I found there is build fail when decode test case [3_close_qrcodes.png]. May I fix this? I cannot find the test image

bit1002lst avatar Sep 14 '22 06:09 bit1002lst

@AleksandrPanov

bit1002lst avatar Sep 14 '22 06:09 bit1002lst

@bit1002lst, 3_close_qrcodes.png (from opencv_extra):

3_close_qrcodes

AleksandrPanov avatar Sep 14 '22 08:09 AleksandrPanov

@AleksandrPanov Hello, I have tested this image and recurrent this error. But, actually, this error is not caused by this PR, because it still exist in top 4.x versions when use_nn_detector is false.

bit1002lst avatar Sep 17 '22 14:09 bit1002lst

@bit1002lst, you broke tests with use_nn_detector = true by adding duplicate qr corners to answer

fixed by this commit: fixed duplicate corners and style

also added test with multi detect

AleksandrPanov avatar Sep 19 '22 20:09 AleksandrPanov

@asmorkalov, could you check PR?

AleksandrPanov avatar Sep 20 '22 06:09 AleksandrPanov

@bit1002lst, you broke tests with use_nn_detector = true by adding duplicate qr corners to answer

fixed by this commit: fixed duplicate corners and style

also added test with multi detect

Thanks for your help

bit1002lst avatar Sep 21 '22 08:09 bit1002lst