opencv_contrib icon indicating copy to clipboard operation
opencv_contrib copied to clipboard

[API Behavior Change] return four vertices of qrcode instead of axis aligned bounding box

Open 109021017 opened this issue 3 years ago • 3 comments

API Behavior Change: return four vertices of qrcode instead of axis aligned bounding box. The change can be tested by the original test files. Related issue: https://github.com/opencv/opencv_contrib/issues/3037 Returning coordinate information of the qrcode detected.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • [x] I agree to contribute to the project under Apache 2 License.
  • [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • [x] The PR is proposed to the proper branch
  • [x] There is a reference to the original bug report and related work
  • [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name.
  • [x] The feature is well documented and sample code can be built with the project CMake
force_builders=linux,docs

109021017 avatar Apr 24 '22 07:04 109021017

@109021017, thx for PR) I think, that need to use the new API in at least one test.

AleksandrPanov avatar Jun 14 '22 12:06 AleksandrPanov

Also you need create a new branch (with a meaningful name) from the base branch you chose. Check https://github.com/opencv/opencv/wiki/How_to_contribute

AleksandrPanov avatar Jun 16 '22 16:06 AleksandrPanov

added fixes and test to new PR fix output qr corners #3289

AleksandrPanov avatar Aug 04 '22 08:08 AleksandrPanov