opencv_contrib icon indicating copy to clipboard operation
opencv_contrib copied to clipboard

PPF3DDetector::read & ::write methods missing

Open Algomorph opened this issue 8 years ago • 3 comments

System information (version)
  • OpenCV => 3.2-dev/master
  • Operating System / Platform => Ubuntu 16.04
  • Compiler => gcc 5.4
Detailed description

This is kind-of a feature request, because it looks like PPF3DDetector::read and ::write were somewhat intended and defined in the ppf_match_3d.hpp header file but never implemented in the ppf_match_3d.cpp file.

Steps to reproduce
  1. Build / install OpenCV with opencv_contrib modules.
  2. Write any short program trying to use the cv::ppf_match_3d::PPF3DDetector::read or ~::write methods. The above results in an (obvious) linker error of the form undefined reference to `cv::ppf_match_3d::PPF3DDetector::read(cv::FileNode const&)'

P.S. interestingly, t_hash_int.cpp has hashtableWrite and hashtableRead methods that use the stdio FILE descriptor to read from / write to binary format. This code cannot possibly be adapted for use with FileStorage unless some kind of base64 conversion is used, but if the latter is done, maybe the new WRITE_BASE64 mode can be used on the FileStorage.

Algomorph avatar Mar 27 '17 20:03 Algomorph

I also meet this problem, has it solve now?

chenshida avatar Dec 26 '19 08:12 chenshida

@chenshida , seems like it has not been solved (see https://github.com/opencv/opencv_contrib/pull/1094#issuecomment-291527015)

Algomorph avatar Dec 26 '19 12:12 Algomorph

Are there any plans to implement trained model saving and loading for the PPF matching module? That would also be accessible from the python ?

jibweb avatar Jun 14 '22 12:06 jibweb