runtime-tools icon indicating copy to clipboard operation
runtime-tools copied to clipboard

generate, validate: isolate gojson* dependencies.

Open klihub opened this issue 3 years ago • 4 comments

Split out those few capability validation functions (LastCap(), CapValid()) which Generator depends on into a validate/capabilities subpackage of their own. This should prevent github.com/xeipuuv/gojson* from sneaking in to the dependencies of anyone who uses Generator for OCI Spec manipulation.

Those gojsonschema and related packages are often considered problematic because they do not seem to be actively maintained. At the time of this commit they received their last updates in 2018, 2019 and 2020. Excluding them from the dependency blast radius can lower the barrier for accepting/allowing import of generate.Generator.

klihub avatar Sep 08 '22 10:09 klihub

Those gojsonschema and related packages are often considered problematic because they do not seem to be actively maintained.

Even without that concern it is better to not pull in additional dependencies that aren't needed. For example, compilation becomes faster.

pohly avatar Sep 08 '22 11:09 pohly

@saschagrunert: thanks. Is there a chance to get this into a tagged release soon(ish)?

pohly avatar Sep 21 '22 16:09 pohly

@kolyshkin PTAL

saschagrunert avatar Sep 22 '22 06:09 saschagrunert

@giuseppe @mrunalp PTAL

rhatdan avatar Oct 12 '22 23:10 rhatdan

@saschagrunert @rhatdan what is still required to get these changes merged?

elezar avatar Oct 26 '22 14:10 elezar