SAI icon indicating copy to clipboard operation
SAI copied to clipboard

Clarification on Conflicting Actions Resolution in ACL Table

Open mholankar opened this issue 1 year ago • 6 comments

ACL table group type represents the way various ACL tables within this * ACL table group perform their lookups. There are two optional values: * Sequential - All the ACL tables are looked up in a sequential order, * which is based on the ACL table priorities and only one ACL entry is matched * with its corresponding ACL entry action applied. In case two ACL tables * have the same priority they are looked up on a first come basis. * Parallel - All the ACL tables within the ACL table groups are looked up * in parallel and non-conflicting actions are resolved and applied from * multiple matched ACL entries (each from different ACL tables of this group). * Conflicting actions are resolved based on the ACL table priorities.

https://github.com/opencomputeproject/SAI/blob/c7a49cce5646bd6793e36b4cc3418dac4ae81ac9/inc/saiacl.h#L363

Could we please understand what are the conflicting actions? I know that forward + drop are conflicting, but drop action always trumps.

What about Copy Cancel + Copy. What happens in case of these two actions? It would be good to know what actions are conflicting and what actions are non-conflicting.

mholankar avatar Jan 31 '24 18:01 mholankar

@kcudnik - could you help with this issue please?

mholankar avatar Feb 05 '24 17:02 mholankar

not sure if i understand the issue here, is this SAI design issue or specific vendor ? + @lguohan

kcudnik avatar Feb 05 '24 18:02 kcudnik

Just trying to understand SAI behavior. Not specific to any vendor

mholankar avatar Feb 22 '24 16:02 mholankar

Gentle ping on this issue. Can we have an understanding on SAI spec or how vendors treat this?

Could we please understand what are the conflicting actions? I know that forward + drop are conflicting, but drop action always trumps.

What about Copy Cancel + Copy. What happens in case of these two actions? It would be good to know what actions are conflicting and what actions are non-conflicting.

mholankar avatar May 07 '24 16:05 mholankar

i dont have deep knowledge about acl groups, can't help here, added @lguohan previously to help point to right direction

kcudnik avatar May 07 '24 19:05 kcudnik