tiktoken icon indicating copy to clipboard operation
tiktoken copied to clipboard

Published 20 hours ago • verified publisher icon openai

Add WASM/JS bindings

Open dqbd opened this issue 2 years ago • 2 comments

This PR builds on top of #40, which introduces both Java bindings and a split Rust core.

dqbd avatar Mar 06 '23 01:03 dqbd

I'm not sure about the timeline of that PR getting merged, so could @hauntsaninja help us get at least the "split rust core" part merged? Or decouple the refactor and the feature work if needed.

Could this have as its base revision the branch of #40 so we can more easily see the changes needed on top of that?

darknoon avatar Mar 07 '23 04:03 darknoon

@darknoon Sure thing, created a separate PR for better code readability (AFAIK Github doesn't allow showing PR to different repositories). https://github.com/eisber/tiktoken/pull/2

I think it would be better to keep this PR as-is for now to indicate the intent of upstreaming.

dqbd avatar Mar 07 '23 16:03 dqbd