openai-cookbook
openai-cookbook copied to clipboard
openai
Zilliz integration and Milvus bugfixes
Included the Zilliz vector database, Milvus bugfixes, and more notebooks.
Also this merge aims to clear the notebook outputs of the shared notebook. Every pull is deleting other peoples outputs and including their own. I believe the best route is to just not have outputs in the notebook instead of everyone overwriting each others work.
Makes sense. Personally I prefer having the outputs pre-computed. That way someone can see the outputs of the example code without necessarily having to run it themselves (e.g., if they're on gibhub.com, or if they don't want to go through the trouble of setting up a vector database but do want to see what it might look like). I do recognize it makes the diffs harder to analyze.
It might be worth having a standard output near the end that shows exactly what should be returned. The different sections just show how to get that input using each vector store.
Is there anything that needs to be changed to get this merged? @ted-at-openai
Merged! Thanks for your patience. I think I'm going to split up the single notebook into one for each vector DB, to help keep things manageable. Hopefully can get that done tomorrow.