openai-cookbook icon indicating copy to clipboard operation
openai-cookbook copied to clipboard

fix embedding model change and quick code edits

Open ankur-oai opened this issue 1 year ago • 5 comments

Summary

This PR bulk-updated older model names and changed this notebook to use text-embedding-3-small but broke it in the process; this notebook relies on comparisons b/w a query string embedding against data from a CSV in our CDN that contains vectors generated with ada-002.

Also:

  • removed some unused variables
  • removed an empty code block at the end of the notebook

Motivation

Why are these changes necessary? How do they improve the cookbook?

Cookbook was not working as expected (bad embedding query results).


For new content

When contributing new content, read through our contribution guidelines, and mark the following action items as completed:

  • [ ] I have added a new entry in registry.yaml (and, optionally, in authors.yaml) so that my content renders on the cookbook website.
  • [ ] I have conducted a self-review of my content based on the contribution guidelines:
    • [ ] Relevance: This content is related to building with OpenAI technologies and is useful to others.
    • [ ] Uniqueness: I have searched for related examples in the OpenAI Cookbook, and verified that my content offers new insights or unique information compared to existing documentation.
    • [ ] Spelling and Grammar: I have checked for spelling or grammatical mistakes.
    • [ ] Clarity: I have done a final read-through and verified that my submission is well-organized and easy to understand.
    • [ ] Correctness: The information I include is correct and all of my code executes successfully.
    • [ ] Completeness: I have explained everything fully, including all necessary references and citations.

We will rate each of these areas on a scale from 1 to 4, and will only accept contributions that score 3 or higher on all areas. Refer to our contribution guidelines for more details.

ankur-oai avatar Mar 13 '24 23:03 ankur-oai

Very good

sarbazvatanatan avatar Apr 18 '24 05:04 sarbazvatanatan

Hard

sarbazvatanatan avatar Apr 18 '24 05:04 sarbazvatanatan

  1. Hdcj

sarbazvatanatan avatar Apr 18 '24 05:04 sarbazvatanatan

Hoo

sarbazvatanatan avatar Apr 18 '24 05:04 sarbazvatanatan


sarbazvatanatan avatar Apr 18 '24 05:04 sarbazvatanatan

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Jun 18 '24 01:06 github-actions[bot]

This PR was closed because it has been stalled for 10 days with no activity.

github-actions[bot] avatar Jun 28 '24 01:06 github-actions[bot]