openai-cookbook icon indicating copy to clipboard operation
openai-cookbook copied to clipboard

[FEATURE] Consider linting or formatting notebooks

Open zanieb opened this issue 1 year ago • 2 comments
trafficstars

I've opened a couple pull requests now resolving syntax errors in notebooks (#1036, #964)

It seems like you should have at least a simple check in CI that notebooks are valid. If you add formatting to CI, you'll get automatic checks for syntax errors and consistent notebook formatting. Alternatively, you use a linter without enabling anything more than syntax errors.

zanieb avatar Feb 02 '24 03:02 zanieb

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Apr 03 '24 01:04 github-actions[bot]

👋 hi bot. I believe this is still relevant.

zanieb avatar Apr 03 '24 01:04 zanieb

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Jun 03 '24 01:06 github-actions[bot]

This issue was closed because it has been stalled for 10 days with no activity.

github-actions[bot] avatar Jun 14 '24 01:06 github-actions[bot]

@shyamal-anadkat would you be willing to consider this or similar? We'd really like to continue using this repository to help verify that changes to our behavior with notebooks is correct, but there are constantly notebooks with syntax errors:

error: Failed to parse examples/Chat_finetuning_data_prep.ipynb:6:18:25: Unparenthesized generator expression cannot be used here
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_confluence.ipynb:15:1:5: Simple statements must be separated by newlines or semicolons
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_gmail.ipynb:15:1:1: Expected an expression
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_jira.ipynb:15:1:1: Expected an expression
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_notion.ipynb:15:1:1: Expected an expression
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_sharepoint_doc.ipynb:28:1:5: Simple statements must be separated by newlines or semicolons
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_sharepoint_text.ipynb:28:1:5: Simple statements must be separated by newlines or semicolons
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_action_sql_database.ipynb:2:2:5: Simple statements must be separated by newlines or semicolons
error: Failed to parse examples/chatgpt/gpt_actions_library/gpt_middleware_azure_function.ipynb:37:1:13: Simple statements must be separated by newlines or semicolons

zanieb avatar Aug 07 '24 14:08 zanieb