open-webui icon indicating copy to clipboard operation
open-webui copied to clipboard

feat(kubernetes)!: Major Helm Chart refactor

Open duhow opened this issue 1 year ago • 11 comments

A major refactor of the Helm Chart, allowing for proper install customization. ~Still WIP, need some additional testing for validation.~

duhow avatar Feb 19 '24 22:02 duhow

@jannikstdl @tjbck have a look 🙏🏻 Let me know any thoughts or additional changes needed.

duhow avatar Feb 23 '24 10:02 duhow

Looks good, thanks. But am not able to test this in prod today.

But did you try to install this chart? Works as expected?

jannikstdl avatar Feb 23 '24 16:02 jannikstdl

Maybe add a value for the two PVCs. They both are hardcoded as data.

Maybe @dnviti @braveokafor can have a look too 🙂

jannikstdl avatar Feb 23 '24 16:02 jannikstdl

@jannikstdl I've tried on a new cluster and worked. You can even create a GitHub E2E action if needed to deploy.

The PVCs are not "named" data .The volume internal name is. PVC name is data-ollama-0 (as per Statefulset name) and open-webui.

duhow avatar Feb 23 '24 16:02 duhow

Forgot 9ee64d8 , the PVC name is already configurable in template.

duhow avatar Feb 23 '24 16:02 duhow

Well nice we will see if others have smt to mention.

jannikstdl avatar Feb 23 '24 16:02 jannikstdl

Let me know if this PR is ready to me merged!

tjbck avatar Feb 23 '24 18:02 tjbck

@tjbck should be. If you want we can wait until next week when I can try this on our cluster.

jannikstdl avatar Feb 23 '24 20:02 jannikstdl

Thanks for the PR @duhow , nice work.

You forgot to add a port name to open-webui service, this is causing the ingress translation to fail since the ingress can't find the http port. Adding a port name (http) should fix this.

Apart from the ingress issue everything else looks fine.

Error:

Translation failed: invalid ingress spec: could not find port "&ServiceBackendPort{Name:http,Number:0,}" in service "ollama/open-webui"

Fix:

--- a/kubernetes/helm/templates/webui-service.yaml
+++ b/kubernetes/helm/templates/webui-service.yaml
@@ -11,6 +11,7 @@ spec:
   type: {{ .type }}
   ports:
   - protocol: TCP
+    name: http
     port: {{ .port }}
     targetPort: http
     {{- if .nodePort }}

braveokafor avatar Feb 23 '24 22:02 braveokafor

Thanks for the check! Somehow still it was working for me 😮

duhow avatar Feb 23 '24 23:02 duhow

Ready to be merged?

tjbck avatar Feb 23 '24 23:02 tjbck

@tjbck LGTM

braveokafor avatar Feb 24 '24 06:02 braveokafor

Thanks everyone!

tjbck avatar Feb 24 '24 06:02 tjbck