owt-server icon indicating copy to clipboard operation
owt-server copied to clipboard

Failed in adding output to video-engine

Open Phillipip opened this issue 1 year ago • 3 comments

In Europe, a frame rate of 25 is common. However, if I try to change the room's frame rate to 25 and add it to the list of allowed frames, I get the error message when subscribing to the stream: Failed in adding output to video-engine. Are there any ideas about this?

Phillipip avatar Jul 16 '24 10:07 Phillipip

If you are using software compositor,

diff --git a/source/agent/video/videoMixer/SoftVideoCompositor.cpp b/source/agent/video/videoMixer/SoftVideoCompositor.cpp
index 0038b594..2ed8a48e 100644
--- a/source/agent/video/videoMixer/SoftVideoCompositor.cpp
+++ b/source/agent/video/videoMixer/SoftVideoCompositor.cpp
@@ -612,9 +612,10 @@ SoftVideoCompositor::SoftVideoCompositor(uint32_t maxInput, VideoSize rootSize,
 
     m_avatarManager.reset(new AvatarManager(maxInput));
 
-    m_generators.resize(2);
+    m_generators.resize(3);
     m_generators[0].reset(new SoftFrameGenerator(this, rootSize, bgColor, crop, 60, 15));
     m_generators[1].reset(new SoftFrameGenerator(this, rootSize, bgColor, crop, 48, 6));
+    m_generators[2].reset(new SoftFrameGenerator(this, rootSize, bgColor, crop, 50, 25));
 }
 
 SoftVideoCompositor::~SoftVideoCompositor()

scripts/build.js -t video-mixer-sw repack video agent

If you're using MsdkVideoCompositor, make similar changes as above.

starwarfan avatar Jul 17 '24 02:07 starwarfan

Thank you for the hint. Wouldn't it be better if the frame and keyframe rate as passed by the room could be used correctly?

Phillipip avatar Jul 17 '24 10:07 Phillipip

Because there was no such requirement before, and various settings will increase testing overhead.

starwarfan avatar Jul 18 '24 05:07 starwarfan