owt-deps-webrtc icon indicating copy to clipboard operation
owt-deps-webrtc copied to clipboard

Published 20 hours ago • verified publisher icon open-webrtc-toolkit

Reduce iOS video enc/dec redundant code, add more H.265 QP parsing logic

Open Piasy opened this issue 4 years ago • 3 comments

Piasy avatar May 09 '21 16:05 Piasy

@Piasy Thanks for you patch. I'm adding @jianjunz to review this.

taste1981 avatar May 10 '21 00:05 taste1981

Thanks for your change. One reason of having both RTCVideoDecoderH264.mm and RTCVideoDecoderH265.mm is HEVC is not included in upstream libwebrtc. Making too many changes to RTCVideoDecoderH264.mm will increase the effort during rebasing. So I would prefer to keep RTCVideoDecoderH264.mm unchanged. As this is a trade off, I'm open to merge these two files if it brings more benefits.

jianjunz avatar May 11 '21 13:05 jianjunz

Hi @jianjunz , as you can see in the diff, the modification to RTCVideoEncoder/DecoderH264 isn't very large, only several #if #else #endif, I don't think it will increase much effort for future rebasing. And if we use separate files for H265, if upstream makes any update or improvement to H264 encoder/decoder, it's not easy to notice them, and apply those changes manually would be annoying.

Piasy avatar May 11 '21 15:05 Piasy