open-runtime-module-library icon indicating copy to clipboard operation
open-runtime-module-library copied to clipboard

Add `transfer_all` to Currencies

Open mzxyz opened this issue 4 years ago • 2 comments

Changes:

  • Add transfer_all to currencies
  • Add test for transfer_all

Not fully understand the requirements for # 375, for tokens module there has already have transfer_all function.

Further steps:

  • [ ] Need to generate correct weight for transfer_all_non_native_currency

mzxyz avatar Feb 22 '21 01:02 mzxyz

I think the best way is add transfer_all to https://github.com/open-web3-stack/open-runtime-module-library/blob/master/traits/src/currency.rs and use it in orml-currencies

Also update the tests to check the case when user have some locked token.

xlc avatar Feb 22 '21 22:02 xlc

I think the best way is add transfer_all to https://github.com/open-web3-stack/open-runtime-module-library/blob/master/traits/src/currency.rs and use it in orml-currencies

Also update the tests to check the case when user have some locked token.

Make sense

mzxyz avatar Feb 23 '21 22:02 mzxyz