open-runtime-module-library icon indicating copy to clipboard operation
open-runtime-module-library copied to clipboard

Xtokens pallet didn't support the PriceForSiblingDelivery

Open sfffaaa opened this issue 1 year ago • 1 comments

Hi, when I try to induce the PriceForSiblingParachainDelivery into our parachain, the related extrinsic in xtoken's pallet cannot work because of NotHoldingFees. I guess the reason is the design of the Xtokens isn't compatible with the concept of PriceForSiblingDelivery. Do I understand right? If so, do you have any suggestions about that?

pub type PriceForSiblingParachainDelivery =                                                                                      
    ExponentialPrice<SelfReserveLocation, BaseDeliveryFee, TransactionByteFee, XcmpQueue>;                                       
                                                                                                     
impl cumulus_pallet_xcmp_queue::Config for Runtime {                                                                             
...
    type PriceForSiblingDelivery = PriceForSiblingParachainDelivery;                                                             
...
}

sfffaaa avatar Sep 23 '24 10:09 sfffaaa

We kinda need XCM v5 with improved fee mechanism to make it work https://github.com/paritytech/polkadot-sdk/pull/5420 Also I would like to put xtokens on maintenance mode and people should migrate to xcm-pallet for the use cases that xtokens doesn't support.

xlc avatar Sep 23 '24 23:09 xlc