opentelemetry.io icon indicating copy to clipboard operation
opentelemetry.io copied to clipboard
verified publisher icon open-telemetry

✅ [outreachy] Added flag button to registry

Open taylorhelene opened this issue 1 year ago • 9 comments

I have added a flag button on the search that adds flags like 'deprecated', 'native' and 'first party'. I have changed these thee components:

  • assets/js/registrySearch.js
  • layouts/partials/ecosystem/registry/entry.html
  • layouts/shortcodes/ecosystem/registry/search-form.html

flags

deprecated

taylorhelene avatar Oct 05 '24 08:10 taylorhelene

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: taylorhelene / name: Taylor (50839fba2c529d8f08837a57834a313d55e1dfcb, dc12484f651c0d0cc891187bf9cf61ba0ceadda7, 23a203d37c58416f6956cb1cd4701af99f09bbc8, b9a1e1d398e685b0efb21ca0e6e54eb7d1c1132e, b5804790e638650c918d8b44766a59ca7c1809a4, 83ad96bc6e595011c8aa87ea606e1daa51ec148f, 6a9fc27248ef665cdaaa5fc94f695cc8aac6da5e)

linux-foundation-easycla[bot] avatar Oct 05 '24 08:10 linux-foundation-easycla[bot]

thanks, this looks really good already. Note that selecting the "first party" flag doesn't work, can you take another look?

svrnm avatar Oct 07 '24 10:10 svrnm

It works when removing spaces from the "first party" flag

taylorhelene avatar Oct 08 '24 08:10 taylorhelene

I have added "first_party" then removed the console logs and prints I had added.

taylorhelene avatar Oct 08 '24 10:10 taylorhelene

lgtm overall, can you do the following please to fix the remaining CI issues:

  • update your branch with the latest commit to main
  • run npm run fix:all locally and commit the changes.

svrnm avatar Oct 10 '24 06:10 svrnm

Do I sync my fork with the latest commits from main or do I push to origin main. I do not understand the first suggestion of updating branch with the latest commit to main.

taylorhelene avatar Oct 10 '24 11:10 taylorhelene

Do I sync my fork with the latest commits from main or do I push to origin main. I do not understand the first suggestion of updating branch with the latest commit to main.

You sync your fork with the latest commit from main, you have done that successfully already what I can see 👍

svrnm avatar Oct 11 '24 07:10 svrnm

Thank you @taylorhelene! This looks really good, I consider this as done! After the outreachy application phase we will take another look and see if we can merge this PR.

svrnm avatar Oct 11 '24 07:10 svrnm

Okay then. Thank you for the directions given.

taylorhelene avatar Oct 11 '24 08:10 taylorhelene

Thank you once again @taylorhelene !

svrnm avatar Nov 11 '24 14:11 svrnm

Also, note the following bug. I'm not sure if it was introduced by this PR or not:

  • #5588

chalin avatar Nov 11 '24 17:11 chalin