opentelemetry.io
opentelemetry.io copied to clipboard
open-telemetry
Update/rust example hyper v1
Supersedes PR#4236
Summary
The HTTP crate hyper has had a major version update (from 0.14 to 1.x; more details at https://hyper.rs/guides/1/upgrading/).
In this PR, I've updated the roll_dice Rust example to use the new major version.
Moreover, the opentelemetry packaging has changed (esp. the refractor of the sdk from the core opentelemetry base crate into its own opentelemetry_sdk). I've updated the example accordingly.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: ekquasar (1bbed7d7a5c9025a8ad3b97e229f75f196c6dd4a, e3cc6e46999a6c42031f995967865421a4fc944f, 843b3206338914d66b6609d6412eec5e47671afe)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
I would wait until https://github.com/open-telemetry/opentelemetry-rust/issues/1427 is resolved.
I would wait until open-telemetry/opentelemetry-rust#1427 is resolved.
I blocked the issue, please update us when we can unblock it
I'm sorry, @hdost , I read that -http thread and it's not clear to me why it's beneficial to wait until other packages update to hyper 1.0? Is it just that e.g. a new dev would follow the example (e.g. this updated one) with hyper 1.x and then try to use the -http exporter which would then barf?
The desire appears to be to "step across the line together" with other projects. I wouldn't advocate that approach, but I understand there may be good reasons to do so.
It's a community question, perhaps for the maintainers, not a technical one; to my understanding.
@open-telemetry/rust-approvers following up, anything we can do for this PR? Close it or instructions for @ekquasar how to get this merged?
@open-telemetry/rust-approvers can you take a look, if we can unblock this PR now? https://github.com/open-telemetry/opentelemetry-rust/issues/1427 is closed now, so please check once again
