opentelemetry-specification icon indicating copy to clipboard operation
opentelemetry-specification copied to clipboard

Randomness requirements following W3C Trace Context level 2

Open jmacd opened this issue 1 year ago • 7 comments

Changes

Updates Trace SDK and Propagator specifications with

  • List W3C propagator requirements (e.g., should propagate tracestate)
  • Introduce W3C Trace Context Level 2 w/ the Random flag
  • Define explicit randomness feature from OTEP 235, OTEP 261
  • Trace SDK default ID generator should include 56 bits of randomness in the correct location
  • Trace SDK for root spans: either set the random flag to confirm the above, or use an explicit randomness value.

Part of #1413. Part of #3602.

Product of the Sampling SIG members @kentquirk @kalyanaj @oertl @PeterF778 and myself.

  • [x] Related issues also #3307, #2253, #2179, #2113, #1947,#1844
  • [x] OTEP: https://github.com/open-telemetry/oteps/pull/235
  • [x] Links to the prototypes: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/probabilisticsamplerprocessor, https://github.com/open-telemetry/opentelemetry-go/pull/5645
  • [x] CHANGELOG.md
  • [x] spec-compliance-matrix.md

jmacd avatar Jul 25 '24 15:07 jmacd

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Aug 15 '24 03:08 github-actions[bot]

@open-telemetry/specs-trace-approvers @open-telemetry/specs-approvers @open-telemetry/technical-committee this PR has reached consensus in the Sampling SIG, we have multiple prototypes implemented, and we are looking for final approvals.

jmacd avatar Aug 15 '24 14:08 jmacd

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Aug 28 '24 03:08 github-actions[bot]

@open-telemetry/specs-trace-approvers @open-telemetry/specs-approvers @open-telemetry/technical-committee this PR has reached consensus in the Sampling SIG, we have multiple prototypes implemented, and we are looking for final approvals.

jmacd avatar Aug 29 '24 14:08 jmacd

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Sep 06 '24 03:09 github-actions[bot]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Sep 27 '24 03:09 github-actions[bot]

Overall LGTM (once some of the latest feedback comments have been addressed).

carlosalberto avatar Oct 11 '24 11:10 carlosalberto

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Oct 30 '24 03:10 github-actions[bot]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Nov 12 '24 03:11 github-actions[bot]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions[bot] avatar Nov 21 '24 03:11 github-actions[bot]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Dec 17 '24 03:12 github-actions[bot]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions[bot] avatar Dec 25 '24 03:12 github-actions[bot]

@open-telemetry/specs-trace-approvers I believe this is ready to merge.

jmacd avatar Feb 13 '25 16:02 jmacd