opentelemetry-rust icon indicating copy to clipboard operation
opentelemetry-rust copied to clipboard

add public functions for AWS trace header

Open garasubo opened this issue 3 years ago • 2 comments

Fix #885

Add public functions to reuse trace header serialize/deserialize logic in this crate

garasubo avatar Sep 28 '22 03:09 garasubo

Is this failure caused by my change? https://github.com/open-telemetry/opentelemetry-rust/actions/runs/3141646959/jobs/5104324937

I believe this change doesn't affect GRPC related part.

---- build_grpc stdout ----
thread 'main' panicked at 'generated file has changed, please commit the change file and rerun the test', opentelemetry-proto/tests/grpc_build.rs:38:5
error: test failed, to rerun pass '-p opentelemetry-proto --test grpc_build'
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

garasubo avatar Sep 28 '22 07:09 garasubo

No, that failure is unrelated.

djc avatar Sep 28 '22 07:09 djc

I think if you merge the upstream changes the test should be fixed

TommyCpp avatar Oct 02 '22 19:10 TommyCpp