opentelemetry-rust icon indicating copy to clipboard operation
opentelemetry-rust copied to clipboard

fix: downgrade NoopMeterProvider log to TRACE

Open thomaseizinger opened this issue 6 months ago • 5 comments

Changes

Downgrade the log about a meter being obtained from the NoopMeterProvider to TRACE. This can be very spammy on systems that request many meters but might have metric collection temporarily disabled.

Merge requirement checklist

  • [x] CONTRIBUTING guidelines followed
  • [ ] Unit tests added/updated (if applicable)
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • [ ] Changes in public API reviewed (if applicable)

thomaseizinger avatar May 14 '25 23:05 thomaseizinger

CLA Not Signed

Oh, I don't want to really bother with this CLA as signing it would require giving away my home address. I guess this PR still serves as a good discussion point. Perhaps one of the maintainers can take this over?

thomaseizinger avatar May 15 '25 00:05 thomaseizinger

Oh, I don't want to really bother with this CLA as signing it would require giving away my home address. I guess this PR still serves as a good discussion point. Perhaps one of the maintainers can take this over?

Not sure if this changes your mind, but that's not true anymore.

https://github.com/open-telemetry/community/issues/1252

hdost avatar May 15 '25 04:05 hdost

Oh, I don't want to really bother with this CLA as signing it would require giving away my home address. I guess this PR still serves as a good discussion point. Perhaps one of the maintainers can take this over?

Not sure if this changes your mind, but that's not true anymore.

open-telemetry/community#1252

Well I tried to go through the process and it still takes me to DocuSign.

thomaseizinger avatar May 15 '25 05:05 thomaseizinger

Oh, I don't want to really bother with this CLA as signing it would require giving away my home address. I guess this PR still serves as a good discussion point. Perhaps one of the maintainers can take this over?

Not sure if this changes your mind, but that's not true anymore.

open-telemetry/community#1252

Well I tried to go through the process and it still takes me to DocuSign.

Having already signed I am not sure how to replicate. However according to https://github.com/open-telemetry/community/issues/1252#issuecomment-2880870319 it no longer requires your home address.

hdost avatar May 15 '25 05:05 hdost