opentelemetry-rust icon indicating copy to clipboard operation
opentelemetry-rust copied to clipboard

fix: Processor now gets passed in reference #2726

Open Puffy1215 opened this issue 8 months ago • 3 comments

Fixes #2726

Changes

See #2726. Previous implementation was not up to spec. I replaced the on_end() trait function parameter with a &mut reference to SpanData, and refactored from there. Cloning still happens inside BatchSpanProcessor where necessary. If there are any unnecessary clones that are still happening that I can fix, please let me know.

Merge requirement checklist

  • [ ] CONTRIBUTING guidelines followed
  • [ ] Unit tests added/updated (if applicable)
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • [ ] Changes in public API reviewed (if applicable)

Puffy1215 avatar Apr 02 '25 14:04 Puffy1215

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: Puffy1215 / name: Andy (3684483062fc86c0310b2fab1d028230459827e3, 4df81349301342a82bae8398cdf169ac3e299e54, b46111180457e5b36e4479a9c0cb6155ddc322e8, 9b1c9d77a790884ce39393626877feca1501f0f0, 6a28b312c31010a86cfeb6f74ca3c8d2c4a19ec9, b7efe129bb3eb14c9d046ece5227003bca993c9e, f4a20805553d7fb7d9ed9146320f60f8f67cab52, 48578a93d0afb6002529b64437beaf571d6d6901, 7d82c3e3327e306eeb8499fe1fcc18e0e4e8cb38, 09989bbf3b8748ff0cb7b37277ec8e11d1124806)
  • :white_check_mark: login: lalitb / name: Lalit Kumar Bhasin (6f81a7d8d87077f038b5225282db4440af712d05)
  • :white_check_mark: login: TommyCpp / name: Zhongyang Wu (33127b007eaace0767618221f42eb78772049585)

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.4%. Comparing base (02c290d) to head (33127b0).

Files with missing lines Patch % Lines
opentelemetry-sdk/src/trace/span.rs 93.7% 1 Missing :warning:
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2895   +/-   ##
=====================================
  Coverage   81.3%   81.4%           
=====================================
  Files        126     126           
  Lines      24251   24256    +5     
=====================================
+ Hits       19736   19745    +9     
+ Misses      4515    4511    -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 02 '25 14:04 codecov[bot]

@Puffy1215 Could you clear the EasyCLA check? The bot comment should have all instructions. You'd probably want to consult your employer if contributing on behalf. (This is a one time requirement, before we can accept contributions) Thank you!

cijothomas avatar Apr 02 '25 14:04 cijothomas