opentelemetry-rust icon indicating copy to clipboard operation
opentelemetry-rust copied to clipboard

fix: AtomicI64, AtomicU64 for xtensa arch

Open brunobrolesi opened this issue 9 months ago • 4 comments

Fixes #

I'm working on a personal project that tries to add observability to an mqtt system with ESP32 microcontrollers. When I tried to use the open telemetry crate to export my program's traces, I encountered the following build error:

image

Changes

After doing some analysis on the subject, I came across the following PR that had the same problem, but for other architectures. Based on the discussion of the PR, I made the changes for the architecture I am using and was able to use the stdout exporter, as can be seen in the image below:

image

One thing to note, this change only allowed me to use the stout exporter, the others had problems due to a compilation error related to the dependencies hyper and socket 2, this problem can be seen in the issues below:

Merge requirement checklist

  • [ ] CONTRIBUTING guidelines followed
  • [ ] Unit tests added/updated (if applicable)
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • [ ] Changes in public API reviewed (if applicable)

brunobrolesi avatar Mar 08 '25 23:03 brunobrolesi

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: brunobrolesi / name: Bruno Brolesi (52ff82a38ff56c5ba26dda808d15d87bddfa502f, d6894e456fbdc200e2f14d170830fd552ddaea1c, 2fca21c837037ecb279405801fce7947fd91d206, e62984262e4824db90d82bef31eb3d0e4cba50d4)
  • :white_check_mark: login: cijothomas / name: Cijo Thomas (8a19adcccc33d57e96e2ac24a61ca25b58497651, e69b7631f3cf759b9d631ee345d097ef49733b38)
  • :white_check_mark: login: hdost / name: Harold Dost (4bd2560e1cf9fb1dd1577fbfa5c0a90bd67ac0d5)

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.3%. Comparing base (5c60f12) to head (4bd2560).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2773   +/-   ##
=====================================
  Coverage   81.3%   81.3%           
=====================================
  Files        126     126           
  Lines      24251   24251           
=====================================
+ Hits       19732   19736    +4     
+ Misses      4519    4515    -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 08 '25 23:03 codecov[bot]

@brunobrolesi Thanks! Can you check if this is only place where Atomics were used? It's okay to do it in a follow up, if you are okay with that. (Trying to make sure we do support extra architectures consistently across repo (wherever feasible))

cijothomas avatar Mar 11 '25 03:03 cijothomas

@brunobrolesi Thanks! Can you check if this is only place where Atomics were used? It's okay to do it in a follow up, if you are okay with that. (Trying to make sure we do support extra architectures consistently across repo (wherever feasible))

https://sourcegraph.com/search?q=std%3A%3Async%3A%3Aatomic%20repo%3Aopentelemetry-rust&patternType=regex

hdost avatar May 02 '25 10:05 hdost