opentelemetry-rust
opentelemetry-rust copied to clipboard
open-telemetry
[Feature]: Name spawned threads
Related Problems?
No response
Describe the solution you'd like:
The TokioCurrentThread spawns threads without names. This makes debugging hard. For example:
thread '<unnamed>' panicked at /home/john/.rhack/tokio-1.37.0/src/runtime/time/entry.rs:557:9:
A Tokio 1.x context was found, but it is being shutdown.
is quite hard to trace back to otel.
I would like each thread spawned by this library to be named
Considered Alternatives
Use the multithreaded tokio runtime which does not spawn. This is currently causing deadlocks (https://github.com/open-telemetry/opentelemetry-rust/issues/1395), so its not acceptable.
Additional Context
No response
BTW, I don't get A Tokio 1.x context was found, but it is being shutdown. after upgrading -- was just an example of a type of issue that would have been easier to debug if the thread was named.
@howardjohn If you'd like to contribute the fix, please feel free to proceed. We eventually plan to eliminate the dependency on the async runtime for batch processors. I'm currently working on this for logs (#1943), and a similar approach would be replicated to traces as well.
BTW turns out the error was actually still happening, opened https://github.com/open-telemetry/opentelemetry-rust/issues/1963. I missed it due to not setting the global trace provider after upgrading :facepalm:
Closing as thread created by PeriodicReader, BatchProcessor uses named thread.
