opentelemetry-rust
opentelemetry-rust copied to clipboard
When deserializing JSON, accept both int and string in 'intValue'
Fixes #1905 Design discussion issue (if applicable) #
Changes
When deserializing JSON, accept both int and string in 'intValue' field of AnyValue.
Merge requirement checklist
- [x] CONTRIBUTING guidelines followed
- [x] Unit tests added/updated (if applicable)
- [ ] Appropriate
CHANGELOG.mdfiles updated for non-trivial, user-facing changes - [ ] Changes in public API reviewed (if applicable)
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: RazvanRotari / name: Razvan Rotari (342e209f1780a97e6c4423715ad0f371a8d09037, b78cc0162de1ca13d81429d19287fabcbf0aca15, 96254abca49f1c4e2100c653aba04cdb5e844f08, f0fd0e72d1c59fec88a8efdbbcc2d65149d41fd9)
- :white_check_mark: login: TommyCpp / name: Zhongyang Wu (c702dc1d35918e4ddad97312167ddeea10f96266)
- :white_check_mark: login: lalitb / name: Lalit Kumar Bhasin (e93b5f04ec40e66e74b354060322fd74174ded43, 0d4f1742d16188b3e9a7fe0887e93f56fca9dd40)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 74.9%. Comparing base (
a9b8621) to head (e93b5f0).
Additional details and impacted files
@@ Coverage Diff @@
## main #1906 +/- ##
=======================================
- Coverage 74.9% 74.9% -0.1%
=======================================
Files 122 122
Lines 20311 20311
=======================================
- Hits 15217 15216 -1
- Misses 5094 5095 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@RazvanRotari Thanks for the PR. Can you also add tests to validate this? There are some relevant unit-tests here - test_serde if that helps.
@lalitb Modified test_serde to check for this case.
@lalitb Hi guys, any updates on this? We also have encountered this problem.
@lalitb @cijothomas Looks like the latest cc crate can't be built with rustc 1.65. Should it be fixed (pinned, I assume?) here or in a separate PR?
@lalitb @cijothomas Looks like the latest
cccrate can't be built with rustc 1.65. Should it be fixed (pinned, I assume?) here or in a separate PR?
I think it was fixed in #1924