opentelemetry-ruby-contrib icon indicating copy to clipboard operation
opentelemetry-ruby-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

feat: add grpc instrumentation

Open hibachrach opened this issue 1 year ago • 3 comments

See https://github.com/hibachrach/opentelemetry-instrumentation-grpc/ for previous git history

Closes #1041

hibachrach avatar Sep 12 '24 06:09 hibachrach

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: hibachrach / name: Hazel Bachrach (d4f07c6b328a29c9075c16295d9d52b1cf7437b8)
  • :white_check_mark: login: kaylareopelle / name: Kayla Reopelle (c2253f3cffbe50f872cb9525093d403c5b7e6eb0, 4b4fada13b61c20fe1f5ad7950499a927422cd76, 92015d3ea92473ae4f9387b32efee3b15422cd60, 8ba7ca3ff6ee0d0b5d4521862d9192b579fb24e5, 59b313ebbf483d07bb2372f87a6dcd2bc548c006, 2b6c708c2f9810e7bbb5e3fa45cceaca6c8dda0a)

linux-foundation-easycla[bot] avatar Sep 12 '24 06:09 linux-foundation-easycla[bot]

Sounds good--happy to align to y'all in any way; no attachment to anything in this PR as it stands.

hibachrach avatar Sep 19 '24 22:09 hibachrach

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

github-actions[bot] avatar Nov 02 '24 01:11 github-actions[bot]

Hello @hibachrach and @kaylareopelle

I’d like to express my interest in contributing to this PR. Of course, @hibachrach has the precedence in responding to the PR review.

My potential contribution could involve either:

  • making changes directly in the fork (for which I’d likely need write access), or
  • implementing changes after this PR is merged.

Let me know how I can best assist!

michal-kazmierczak avatar Nov 20 '24 16:11 michal-kazmierczak

Go for it! My personal life has been quite busy so I haven't had the opportunity to contribute here.

hibachrach avatar Nov 20 '24 23:11 hibachrach

@michal-kazmierczak, thanks for expressing your interest! And thank you, @hibachrach, for chiming in!

@michal-kazmierczak - to make things easier for you to contribute, I think we should merge this PR, knowing that the gem isn't ready for OpenTelemetry to release just yet. I'll open up an issue tomorrow with more detailed steps on what we need to take care of before we can release a new version under the open-telemetry org.

If any maintainers/approvers disagree with this approach, please let me know!

kaylareopelle avatar Nov 21 '24 01:11 kaylareopelle

I'm ok with that as long as the unfinished gem isn't releasable or a dependency of the all gem.

arielvalentin avatar Nov 21 '24 02:11 arielvalentin