opentelemetry-python icon indicating copy to clipboard operation
opentelemetry-python copied to clipboard

Configurable max export delay value for OTLPExporterMixin

Open avpps opened this issue 2 years ago • 2 comments

Description

Change related with https://github.com/open-telemetry/opentelemetry-python/pull/1842.

Default OTLPExporterMixin approach to retry exporting with hardcoded time range, causes issues when using it in short lasting processes and opentelemetry collector is not available. Here is example where it "hangs" whole process execution: https://github.com/avpps/opentelemetry-python-examples/blob/master/examples/trace.py

I just moved hardcoded value to make it configurable. In my cases it make sense to not retry export at all.

Type of change

  • [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

OTLPExporterMixin tests pass after change.

Does This PR Require a Contrib Repo Change?

  • [x] No.

Checklist:

  • [x] Followed the style guidelines of this project

avpps avatar Nov 27 '23 16:11 avpps

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: avpps / name: Piotr (36400f65287051ffc2b0b07f64bbfe137a357255, 0cd8bf0a8f580ab75a49006f7539293b4d64c000)
  • :white_check_mark: login: ocelotl / name: Diego Hurtado (311d935055ad2f40cd126279688a402a710975b8)

I could also use this feature, it would be nice in our setup.

jakobdo avatar Nov 29 '23 08:11 jakobdo